search

saltyrtc / saltyrtc-client-java

SaltyRTC Java implementation.
Apache License 2.0
3 stars 4 forks source link

Remove use of java.util.Optional #111

Closed ovalseven8 closed 5 years ago

ovalseven8 commented 5 years ago

Ensure compatibility with Android API level < 24.

https://developer.android.com/reference/java/util/Optional

ovalseven8 commented 5 years ago

Rebased.

ovalseven8 commented 5 years ago

Question: I guess this client is being used in Threema's Android app. Is the Android API < 24 compatibility for other users of this client? It looks like using Optional was no problem so far?

lgrahl commented 5 years ago

Maybe because the initiator role is not being used by the app.

ovalseven8 commented 5 years ago

A suggestion: For future pushes, prefer git commit --fixup over amending. This allows us to keep track of what has changed between reviews and squash once approved.

Thanks, didn't know this feature. :+1: