search

saltyrtc / saltyrtc-client-java

SaltyRTC Java implementation.
Apache License 2.0
3 stars 4 forks source link

Change wording & add code highlighting #51

Closed rugk closed 7 years ago

rugk commented 7 years ago

SHA256 hashes are not signatures, but hashes…

For real signatures I'd recommend signing your git tags.

dbrgn commented 7 years ago

Same as https://github.com/saltyrtc/saltyrtc-task-webrtc-java/pull/9#issuecomment-262635707.

Our tags are actually signed (signing key is E7ADD9914E260E8B35DFB50665FDE935573ACDA6).

dbrgn commented 7 years ago

By the way, why are your commits 11 minutes in the future? It even breaks the git commit form...

rugk commented 7 years ago

Our tags are actually signed (signing key is E7ADD9914E260E8B35DFB50665FDE935573ACDA6).

Nice, in this case you just missed to upload your key on GitHub. Sorry for the wrong-dated commits. Had a wrong system clock here.

dbrgn commented 7 years ago

Nice, in this case you just missed to upload your key on GitHub.

Nope, it's the Threema key, not my personal one. Even if I'd upload it, it wouldn't be shown correctly because the e-mail doesn't match mine. And Github doesn't render tag signatures anyways as far as I know.

You can verify signatures on the command line instead.

dbrgn commented 7 years ago

Thanks!