search

saltyrtc / saltyrtc-client-java

SaltyRTC Java implementation.
Apache License 2.0
3 stars 4 forks source link

Wrong send-error validation #99

Closed dbrgn closed 5 years ago

dbrgn commented 5 years ago

https://github.com/saltyrtc/saltyrtc-client-java/blob/bd07901779569152577ca918ec5e673256f59e02/src/main/java/org/saltyrtc/client/messages/s2c/SendError.java#L31

03-28 21:03:50.410 19412  8296 W System.err: org.saltyrtc.client.exceptions.ValidationError: id must be 32 bytes long, not 8
03-28 21:03:50.419 19412  8296 W System.err:    at org.saltyrtc.client.helpers.ValidationHelper.validateByteArray(ValidationHelper.java:47)
03-28 21:03:50.419 19412  8296 W System.err:    at org.saltyrtc.client.messages.s2c.SendError.<init>(SendError.java:31)
03-28 21:03:50.419 19412  8296 W System.err:    at org.saltyrtc.client.helpers.MessageReader.read(MessageReader.java:98)
03-28 21:03:50.419 19412  8296 W System.err:    at org.saltyrtc.client.helpers.MessageReader.read(MessageReader.java:45)
03-28 21:03:50.419 19412  8296 W System.err:    at org.saltyrtc.client.signaling.ResponderSignaling.onPeerHandshakeMessage(ResponderSignaling.java:372)
03-28 21:03:50.419 19412  8296 W System.err:    at org.saltyrtc.client.signaling.Signaling$1.onBinaryMessage(Signaling.java:383)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.ListenerManager.callOnBinaryMessage(ListenerManager.java:385)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.ReadingThread.callOnBinaryMessage(ReadingThread.java:276)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.ReadingThread.handleBinaryFrame(ReadingThread.java:996)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.ReadingThread.handleFrame(ReadingThread.java:755)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.ReadingThread.main(ReadingThread.java:108)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.ReadingThread.runMain(ReadingThread.java:64)
03-28 21:03:50.420 19412  8296 W System.err:    at com.neovisionaries.ws.client.WebSocketThread.run(WebSocketThread.java:45)

https://github.com/saltyrtc/saltyrtc-meta/blob/master/Protocol.md#send-error-message