saltyrtc / saltyrtc-client-js

SaltyRTC JavaScript implementation.
MIT License
29 stars 6 forks source link

Store sent messages #62

Open dbrgn opened 7 years ago

dbrgn commented 7 years ago

...so that when logging a send-error message, we actually know which message was lost.

lgrahl commented 7 years ago

I'd only do that in debug mode though.

dbrgn commented 7 years ago

@lgrahl the Java version implements that currently:

Do you think it should be removed?

lgrahl commented 7 years ago

I think it should be active in debug mode only.

dbrgn commented 7 years ago

Reason? Performance?

lgrahl commented 7 years ago

No, I just want to be cautious when giving out detailed error reasons. Think of the padding oracle attack on SSL.

lgrahl commented 7 years ago

I misinterpreted this thread's topic (dunno why). Sure, logging these messages should be fine.

What I was referring to was WebSocket close code reasons.