search

saltyrtc / saltyrtc-server-python

SaltyRTC signalling server implementation.
MIT License
59 stars 13 forks source link

Fix path duplication #114

Closed lgrahl closed 5 years ago

lgrahl commented 5 years ago

Fix a race condition that leads to path duplication

This adds a pending set of clients to the Path instance which prevents it from being removed while another client is currently in the handshake process.

Depends on #116

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@082a7d2). Click here to learn what that means. The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage          ?   82.85%           
=========================================
  Files             ?       11           
  Lines             ?     1831           
  Branches          ?      217           
=========================================
  Hits              ?     1517           
  Misses            ?      242           
  Partials          ?       72
Impacted Files Coverage Δ
saltyrtc/server/__init__.py 100% <ø> (ø)
saltyrtc/server/protocol.py 86.76% <50%> (ø)
saltyrtc/server/server.py 88.47% <88.46%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 082a7d2...82750c9. Read the comment docs.