search

saltyrtc / saltyrtc-server-python

SaltyRTC signalling server implementation.
MIT License
59 stars 13 forks source link

Upgrade mypy to 0.780 #120

Closed dbrgn closed 3 years ago

dbrgn commented 4 years ago

Version 0.700 is not compatible with Python 3.8.

dbrgn commented 4 years ago

I think the tests fail because some test dependencies were not sufficiently pinned. From the pip install logs:

ERROR: pytest-asyncio 0.14.0 has requirement pytest>=5.4.0, but you'll have pytest 3.10.1 which is incompatible.
ERROR: pytest-cov 2.10.1 has requirement pytest>=4.6, but you'll have pytest 3.10.1 which is incompatible.
ERROR: pytest-mock 3.3.0 has requirement pytest>=5.0, but you'll have pytest 3.10.1 which is incompatible.

I'll fix the mypy errors.

dbrgn commented 4 years ago

Linting check still fails because the isort dependency wasn't properly pinned and changed behavior in the meantime. @lgrahl I leave it to you whether you want to update import sort order, or whether you also want to update the version specifier. (I'm a big fan of pinning dev dependencies, btw :stuck_out_tongue:)

Edit: Isort updated in #122.