search

saltyrtc / saltyrtc-server-python

SaltyRTC signalling server implementation.
MIT License
59 stars 13 forks source link

Fix invalid order of messages & invalid send-error ID #78

Closed lgrahl closed 6 years ago

lgrahl commented 6 years ago

Until now, a disconnected message slipped in before the send-error message has been sent. Furthermore, an invalid message ID has been sent in the send-error message (which we will likely remove anyway).

Resolves #77

lgrahl commented 6 years ago

@dbrgn can you verify that the ID of a send-error message matches the ID of the sent message as you would expect it to be?

lgrahl commented 6 years ago

Bumpedibump

lgrahl commented 6 years ago

I don't think this can be tested from the client side. What you could test is if no other peer is connected and you send a relay message. Then you would get a send-error. However, be aware we will probably remove it anyway.

dbrgn commented 6 years ago

Ok, then I guess the server-side test is sufficient.