Closed lgrahl closed 5 years ago
We always get this output from isort -rc -df but I think the sorting is actually fine and the proposed changes of isort are ugly:
isort -rc -df
ERROR: /saltyrtc-server-python/saltyrtc/server/message.py Imports are incorrectly sorted. ERROR: /saltyrtc-server-python/tests/test_cli.py Imports are incorrectly sorted. --- /saltyrtc-server-python/saltyrtc/server/message.py:before 2018-07-09 17:18:19.324564 +++ /saltyrtc-server-python/saltyrtc/server/message.py:after 2018-08-29 18:01:28.881520 @@ -7,7 +7,6 @@ import libnacl import umsgpack -from .common import sign_keys as sign_keys_ from .common import ( COOKIE_LENGTH, DATA_LENGTH_MIN, @@ -17,6 +16,9 @@ CloseCode, MessageType, OverflowSentinel, +) +from .common import sign_keys as sign_keys_ +from .common import ( validate_client_id, validate_cookie, validate_drop_reason, --- /saltyrtc-server-python/tests/test_cli.py:before 2018-08-27 18:03:56.773474 +++ /saltyrtc-server-python/tests/test_cli.py:after 2018-08-29 18:01:28.916764 @@ -6,11 +6,9 @@ import pytest +from saltyrtc.server import Server from saltyrtc.server import __version__ as _version -from saltyrtc.server import ( - Server, - util, -) +from saltyrtc.server import util class TestCLI: Skipped 2 files
You could also just run isort locally and not as a condition for successful CI.
Yeah but that doesn't solve the main problem.
We always get this output from
isort -rc -df
but I think the sorting is actually fine and the proposed changes of isort are ugly: