search

saltyshiomix / ark

An easiest authentication system on top of NestJS, TypeORM, NEXT.js(v9.3) and Material UI(v4).
MIT License
259 stars 17 forks source link

Added fixes from upstream material-ui nextjs examples #4

Closed neonfuz closed 5 years ago

neonfuz commented 5 years ago

While working on the code, I encountered some strange errors which resulted in an undefined pageContext. The error was caused earlier on in middleware, but the undefined pageContext was crashing the server before the real error message could even get to the browser to be displayed.

While searching for a solution, I found what I believe was the upstream for your _dashboard file, but with fixes for the errors I was encountering. I've also included more upstream code from _app that should probably be included, and deferred the themeColor in a similar way to the css.

upstream: https://github.com/mui-org/material-ui/tree/master/examples/nextjs

saltyshiomix commented 5 years ago

@neonfuz

Thank you for your big efforts!! I checked your folk and test all commits, and there is no problem 👍

I greatly appreciate your clean commits and PRs ❤️