search

saltyshiomix / nextron

⚡ Next.js + Electron ⚡
https://npm.im/nextron
MIT License
3.97k stars 229 forks source link

publish #45

Closed bkniffler closed 5 years ago

bkniffler commented 5 years ago

Hi, Whats the recommended way to publish? I know I can use electron-builder --publish, but this will also rebuild the application bundles. And nextron build will also always build application bundles, so I'm not sure how to build & publish without building twice.

The best solution for me would be to have nextron build which would only create JS bundles. Or if nextron would accept the --publish argument. Or do I miss something?

bkniffler commented 5 years ago

Here is one possible solution, feel free to close the PR if you don't like that approach: https://github.com/saltyshiomix/nextron/pull/46

bkniffler commented 5 years ago

Oh, I noticed I can still publish through electron builder config. Nevermind :)

saltyshiomix commented 5 years ago

@bkniffler

No problem :) If you have any questions, feel free to contact me 👍

zdenham commented 4 years ago

@bkniffler How did you end up configuring it to publish with electron builder config? Just including the "publish" key didn't work for me, so currently I'm building twice:

  "build": "nextron build",
  "release": "yarn run build && electron-builder --publish always",
bkniffler commented 4 years ago

This should work: 

{
 "build": "nextron build",
 "release": "nextron build"
}

Electron builder should detect it is called from release script and take care of everything.