search

salute-developers / plasma

Salute Design System
MIT License
29 stars 20 forks source link

feat(plasma-new-hope, web, b2c): Dropdown refactoring #1201

Closed shuga2704 closed 2 months ago

shuga2704 commented 2 months ago

Dropdown

What/why changed

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @salutejs/caldera-online@0.38.0-canary.1201.9002676480.0 npm install @salutejs/plasma-asdk@0.76.0-canary.1201.9002676480.0 npm install @salutejs/plasma-b2c@1.318.0-canary.1201.9002676480.0 npm install @salutejs/plasma-new-hope@0.78.0-canary.1201.9002676480.0 npm install @salutejs/plasma-web@1.319.0-canary.1201.9002676480.0 npm install @salutejs/sdds-serv@0.44.0-canary.1201.9002676480.0 # or yarn add @salutejs/caldera-online@0.38.0-canary.1201.9002676480.0 yarn add @salutejs/plasma-asdk@0.76.0-canary.1201.9002676480.0 yarn add @salutejs/plasma-b2c@1.318.0-canary.1201.9002676480.0 yarn add @salutejs/plasma-new-hope@0.78.0-canary.1201.9002676480.0 yarn add @salutejs/plasma-web@1.319.0-canary.1201.9002676480.0 yarn add @salutejs/sdds-serv@0.44.0-canary.1201.9002676480.0 ```
github-actions[bot] commented 2 months ago

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1201/

github-actions[bot] commented 2 months ago

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1201/ caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1201/caldera-online-storybook/ asdk storybook: https://plasma.sberdevices.ru/pr/pr-1201/asdk-storybook/ b2c storybook: https://plasma.sberdevices.ru/pr/pr-1201/b2c-storybook/ new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1201/new-hope-storybook/ web storybook: https://plasma.sberdevices.ru/pr/pr-1201/web-storybook/ sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1201/sdds-serv-storybook/ ui storybook: https://plasma.sberdevices.ru/pr/pr-1201/ui-storybook/

github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🟢 OK

neretin-trike commented 2 months ago

странновато ведёт себя дропдаун, когда нажимаешь 'PageUp' находясь на втором и ниже уровнях

https://github.com/salute-developers/plasma/assets/26903236/3a88f979-22ac-4ec0-bd46-445d22f1cc46

github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🟢 OK

shuga2704 commented 2 months ago

странновато ведёт себя дропдаун, когда нажимаешь 'PageUp' находясь на втором и ниже уровнях

Screen.Recording.2024-05-06.at.11.48.21.mov

Fixed

github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🔴 FAIL

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 14.00 pts (+53.24%) | 26.30 pts | 40.29 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 9.67 pts (+31.51%) | 30.69 pts | 40.36 pts | **rerender:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.69 pts (+236.19%) | 10.45 pts | 35.14 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.30 pts (+223.27%) | 10.89 pts | 35.19 pts |
github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🔴 FAIL

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 14.20 pts (+53.36%) | 26.61 pts | 40.81 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 9.48 pts (+30.35%) | 31.22 pts | 40.70 pts | **rerender:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 25.14 pts (+230.72%) | 10.90 pts | 36.04 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.66 pts (+219.40%) | 11.24 pts | 35.90 pts |
github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🔴 FAIL

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 13.91 pts (+52.98%) | 26.27 pts | 40.18 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 9.64 pts (+31.68%) | 30.43 pts | 40.07 pts | **rerender:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.32 pts (+234.58%) | 10.37 pts | 34.69 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.17 pts (+226.48%) | 10.67 pts | 34.85 pts |
github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🔴 FAIL

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 14.29 pts (+53.88%) | 26.53 pts | 40.82 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 9.95 pts (+32.17%) | 30.94 pts | 40.89 pts | **rerender:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 25.05 pts (+236.05%) | 10.61 pts | 35.66 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.76 pts (+225.97%) | 10.96 pts | 35.72 pts |
github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🔴 FAIL

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 14.48 pts (+53.80%) | 26.92 pts | 41.40 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 9.91 pts (+31.60%) | 31.35 pts | 41.25 pts | **rerender:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 25.37 pts (+236.67%) | 10.72 pts | 36.08 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 24.85 pts (+219.69%) | 11.31 pts | 36.16 pts |
github-actions[bot] commented 2 months ago

⚡ Component performance testing

Result: 🔴 FAIL

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 14.65 pts (+52.77%) | 27.76 pts | 42.40 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 9.96 pts (+30.67%) | 32.48 pts | 42.44 pts | **rerender:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-web/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 26.06 pts (+234.97%) | 11.09 pts | 37.15 pts | | packages/plasma-b2c/src/components/Dropdown/Dropdown.perftest.tsx#Trigger_mode1 | 25.33 pts (+220.05%) | 11.51 pts | 36.84 pts |