salute-developers / plasma

Salute Design System
MIT License
29 stars 20 forks source link

Fix checkbox types #1217

Closed iljs closed 4 months ago

iljs commented 4 months ago

Checkbox/Radiobox

What/why changed

Убрал принудительно поставленный тип в этих библиотеках. Теперь код аналогичен web и b2c

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @salutejs/caldera-online@0.46.1-canary.1217.9271710675.0 npm install @salutejs/plasma-asdk@0.84.1-canary.1217.9271710675.0 npm install @salutejs/plasma-b2c@1.326.1-canary.1217.9271710675.0 npm install @salutejs/plasma-new-hope@0.86.1-canary.1217.9271710675.0 npm install @salutejs/plasma-web@1.327.1-canary.1217.9271710675.0 npm install @salutejs/sdds-serv@0.54.1-canary.1217.9271710675.0 # or yarn add @salutejs/caldera-online@0.46.1-canary.1217.9271710675.0 yarn add @salutejs/plasma-asdk@0.84.1-canary.1217.9271710675.0 yarn add @salutejs/plasma-b2c@1.326.1-canary.1217.9271710675.0 yarn add @salutejs/plasma-new-hope@0.86.1-canary.1217.9271710675.0 yarn add @salutejs/plasma-web@1.327.1-canary.1217.9271710675.0 yarn add @salutejs/sdds-serv@0.54.1-canary.1217.9271710675.0 ```
github-actions[bot] commented 4 months ago

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1217/

github-actions[bot] commented 4 months ago

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1217/ caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1217/caldera-online-storybook/ asdk storybook: https://plasma.sberdevices.ru/pr/pr-1217/asdk-storybook/ b2c storybook: https://plasma.sberdevices.ru/pr/pr-1217/b2c-storybook/ new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1217/new-hope-storybook/ web storybook: https://plasma.sberdevices.ru/pr/pr-1217/web-storybook/ sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1217/sdds-serv-storybook/ ui storybook: https://plasma.sberdevices.ru/pr/pr-1217/ui-storybook/

github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 🟢 OK

github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 🟢 OK

github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken. If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair. For any questions, come to the Speed team.

github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 🟢 OK

github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 🟢 OK

github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 🟢 OK

Details
**render:** | Component | Diff | Base value | Current value | |:-:|:-:|:-:|:-:| | packages/plasma-asdk/src/components/Checkbox/Checkbox.perftest.tsx#Default_modeCount | | 2.00 pts | 1.00 pts |
github-actions[bot] commented 4 months ago

⚡ Component performance testing

Result: 🟢 OK