search

salute-developers / plasma

Salute Design System
MIT License
29 stars 20 forks source link

`plasma-*, sdds-*`: fix `Attach` `square` prop #1525

Closed denivladislav closed 1 week ago

denivladislav commented 2 weeks ago

Attach, Button

IconButton

What/why changed

Before

before

view=secondary

view=secondary_before

After

after

view=secondary

view=secondary_after
📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @salutejs/plasma-asdk@0.202.1-canary.1525.11803660289.0 npm install @salutejs/plasma-b2c@1.444.1-canary.1525.11803660289.0 npm install @salutejs/plasma-new-hope@0.192.1-canary.1525.11803660289.0 npm install @salutejs/plasma-web@1.446.1-canary.1525.11803660289.0 npm install @salutejs/sdds-cs@0.175.1-canary.1525.11803660289.0 npm install @salutejs/sdds-dfa@0.172.1-canary.1525.11803660289.0 npm install @salutejs/sdds-finportal@0.166.1-canary.1525.11803660289.0 npm install @salutejs/sdds-insol@0.165.1-canary.1525.11803660289.0 npm install @salutejs/sdds-serv@0.173.1-canary.1525.11803660289.0 # or yarn add @salutejs/plasma-asdk@0.202.1-canary.1525.11803660289.0 yarn add @salutejs/plasma-b2c@1.444.1-canary.1525.11803660289.0 yarn add @salutejs/plasma-new-hope@0.192.1-canary.1525.11803660289.0 yarn add @salutejs/plasma-web@1.446.1-canary.1525.11803660289.0 yarn add @salutejs/sdds-cs@0.175.1-canary.1525.11803660289.0 yarn add @salutejs/sdds-dfa@0.172.1-canary.1525.11803660289.0 yarn add @salutejs/sdds-finportal@0.166.1-canary.1525.11803660289.0 yarn add @salutejs/sdds-insol@0.165.1-canary.1525.11803660289.0 yarn add @salutejs/sdds-serv@0.173.1-canary.1525.11803660289.0 ```
github-actions[bot] commented 2 weeks ago

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1525/

github-actions[bot] commented 2 weeks ago

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1525/ asdk storybook: https://plasma.sberdevices.ru/pr/pr-1525/asdk-storybook/ b2c storybook: https://plasma.sberdevices.ru/pr/pr-1525/b2c-storybook/ new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1525/new-hope-storybook/ web storybook: https://plasma.sberdevices.ru/pr/pr-1525/web-storybook/ sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1525/sdds-cs-storybook/ sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1525/sdds-dfa-storybook/ sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1525/sdds-finportal-storybook/ sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1525/sdds-insol-storybook/ sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1525/sdds-serv-storybook/ ui storybook: https://plasma.sberdevices.ru/pr/pr-1525/ui-storybook/

Yakutoc commented 1 week ago

@denivladislav для кнопки в Attach view secondary нужно поправить значения

Взято из packages/sdds-cs/src/components/Button/Button.config.ts

${buttonTokens.buttonColor}: var(--text-accent);
${buttonTokens.buttonColorHover}: var(--text-accent-hover);
${buttonTokens.buttonColorActive}: var(--text-accent-active);

Вот так сейчас на проде для кнопки

https://plasma.sberdevices.ru/sdds-cs-storybook/?path=/story/controls-button--default&args=view:secondary