Challenge 1 Feedback - Githubissues

salvadb23 / CS2.2

A repo for my computer science class on graphs and recursion

0 stars 0 forks source link

Open meredithcat opened 5 years ago

meredithcat commented 5 years ago

Challenge 1 Feedback: 5/20 Feedback based on Challenge 1 Rubric

Solution: 1 (x2 = 2)
- Does not read from a given input file (it looks like you commented this out)
- Treats all graphs as directed graphs
- Does not handle 'D' in input file (causes an exception)
Documentation: 1
- Add docstrings to all functions, e.g. parse_data and create_graph
Organization: 2
- create_graph does not have clear responsibilities, as it is both creating and printing the graph
Testing: 0
- Add unit tests

salvadb23 commented 5 years ago

updated

meredithcat commented 5 years ago

Challenge 1 Feedback: 10/20

Solution: 2 (x2 = 4)
- Handles directed/undirected, weighted/unweighted
- Throws a KeyError if an edge contains a new vertex (should throw a custom error or create the new vertex)
Documentation: 2
- All functions contain docstrings, but formatting is not consistent
Organization: 3
- looks good.
Testing: 1
- Does not test Vertex class, parse_data, create_graph, or print_graph