search

salvadorc17 / Prince-Monogame

Monogame implementation of Prince of Persia 2
GNU General Public License v2.0
43 stars 8 forks source link

Kid_166.xnb does not exist. #2

Closed fungunoid closed 7 years ago

fungunoid commented 7 years ago

Kid_166 is referenced in KID_sequence.xml but does not exist in Content/Sprites/Player/dos nor in Content/Sprites/Player/alternate. This causes runtime exceptions in Sequence.cs Line 70 (below).

Please commit missing files, fix the sequences, or include the raw image files that the XNB files are based off of so someone else may see the sprites and figure out the correct sequence.

Exception thrown: 'System.Collections.Generic.KeyNotFoundException' in mscorlib.dll ERROR:Content.LoadSystem.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.Collections.Generic.Dictionary`2.get_Item(TKey key) at PrinceGame.Sequence.Initialize(ContentManager Content) in Prince-Monogame\PrinceGame\Animation\Sequence.cs:line 69CONFIG_SPRITE_KIDKid_166

salvadorc17 commented 7 years ago

Who are you, and why interested in source?

fungunoid commented 7 years ago

I'd like to help because I'd like to be able to play this game again with the Mac graphics and music by using a controller like I use to do in Sand of Time on the XBox. You seem to have a decent start here.

The Visual Studio project file is, I assume, out of date. I had to change reference library versions, include the new sprite content directories, and make changes to the code to account for the changes you made in the content folders to get it to build without errors. As you can guess from the above, I was able to get the game up and running. Seems like an intro sequence works fine, but I get a loop of runtime exceptions because of the missing 166 file with a black screen when the game is supposed to run.

I found the source code that you based this off of (originally in VB, correct?) and it looks like you're straight porting it to MonoGame and C#. That source didn't have the Kid_166 file either. I looked at Jordan Mechner's source code as well, and it looks like the VB code pretty much just formatted Mechner's original sequence table into XML. I don't know how to rip that frame from the binary files Mechner posted though. That's old stuff. The VB code did have some sprite frames in PNG format though for the dos version. I can try to look through those and match up what 166 should be, or is closest too. I just don't know what ALERTSTAND means in terms of the character pose/action. princed.org also has some tools to extract images from the DOS data files, so maybe I can find it in there as well.

salvadorc17 commented 7 years ago

I have fixed problem with the missing sprites, but if you want to do changes or updates to newer version, will need to fork your own repository, im currently only interested in code to allow game engine completion.

fungunoid commented 7 years ago

Then why don't you commit your changes to GitHub?

On Dec 13, 2016 1:38 PM, "Salvador Cabañas" notifications@github.com wrote:

I have fixed problem with the missing sprites, but if you want to do changes or updates to newer version, will need to fork your own repository, im currently only interested in code to allow game engine completion.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/salvadorc17/Prince-Monogame/issues/2#issuecomment-266854905, or mute the thread https://github.com/notifications/unsubscribe-auth/AQbOb2nt_Rwo3SkgFZBNMqht_iFv23Clks5rHwJSgaJpZM4LKDnt .

salvadorc17 commented 7 years ago

Was a mistake i forgot to fix, but anyway this is not really issue.