salvogiangri / KnoxPatch

LSPosed module to get Samsung apps/features working again in your rooted Galaxy device.
GNU General Public License v3.0
688 stars 31 forks source link

Samsung Health application still getting "Unauthorised changes" error. #21

Closed morganlabs closed 1 year ago

morganlabs commented 1 year ago

OneUI: 5.1 Phone: Galaxy A71

I pass SafetyNet attestation at basic integrity and CTS profile check (if that matters). I'm using KnoxPatch + Enhancer.

KnoxPatch worked before I reset my phone (as it was getting slow), including Samsung Health.

Galaxy Wearable works flawlessly, so I know KnoxPatch is doing its job. But opening SHealth gives this error. It is selected in KnoxPatch settings, but it is also showing as "on denylist" for some reason.

If there's any extra information I need to give to you, I'd be happy to.

salvogiangri commented 1 year ago

As of today, SafetyNet/Play Integrity status isn't checked by the Samsung apps to verify the device integrity status. Would be useful to have some system/LSPosed logs to see what's going on. Give also a try to delete the app data in Samsung Health and also force close the app, reboot the system as well if possible.

morganlabs commented 1 year ago

I've already tried (and retried) clearing cache, clearing all app data, force quitting and rebooting. All to no avail. Samsung Health is definitely in Magisk Hide and I've also hidden the Magisk Hide app too.

My LSposed logs (Google Drive)

salvogiangri commented 1 year ago

You shouldn't be adding any Samsung apps in DenyList/Magisk Hide, KnoxPatch module alone already takes care of all the checks in the apps. From the logs you sent it looks like something is conflicting with LSPosed since I can't see the Samsung Health app hooks applied in modules*.log logs in the archive. What I can see tho is LSPosed reporting the hooks might have no effect since you did put some Samsung apps in your Zygisk deny list:

[ 2023-05-12T13:14:11.640        0:   873:  1033 W/LSPosedService  ] com.sec.android.app.shealth is on denylist. It may not take effect.
[ 2023-05-12T13:14:11.646        0:   873:  1033 W/LSPosedService  ] com.osp.app.signin is on denylist. It may not take effect.
[ 2023-05-12T13:14:11.649        0:   873:  1033 W/LSPosedService  ] com.samsung.android.spay is on denylist. It may not take effect.

Try clearing your Deny List and add only the apps that you're actually having issues with.

salvogiangri commented 1 year ago

I tried emulating your case by adding such apps in my Deny List and I can confirm that this does indeed prevent LSPosed to apply hooks in those apps:


Clean up your Deny List by removing all the apps you selected, expecially Samsung ones, as I said this module alone already takes care of all of them. You should then have Samsung Health working in your end (just tested the latest available version with the latest OS build available for my device):

morganlabs commented 1 year ago

Ah! That was the issue, thank you so much. The second I removed them from the Zygisk denylist, the "On Denylist" message disappeared. Thank you so much.