salvogiangri / KnoxPatch

LSPosed module to get Samsung apps/features working again in your rooted Galaxy device.
GNU General Public License v3.0
688 stars 31 forks source link

[REQUEST] Make a script for rom implementation #30

Closed glikched closed 1 year ago

glikched commented 1 year ago

Please make a script for setting props so users can experience it on any rom with no root.

For Samsung Health and Secure Folder

salvogiangri commented 1 year ago

The main purpose of this module is to be systemless (leave the OS partitions untouched), reversable (the module can be disabled/uninstalled with ease) and future-proof/compatible with a wide range of devices, this is achieved thanks to both Magisk and the Xposed API's. Creating a script that manually applies the required patches in system is both not planned, as it breaks all the fundaments the module is based, and also way more "tricky" than applying the patches on the fly, let me clear this out.

First thing first root is required regardless, since to apply the required system patches you need r/w access to the OS partitions to replace the required files, this is not anymore the case on modern devices since Google introduced dynamic partitions or due to r/o partitions (F2FS or EROFS for devices shipped with A13).

Second, while some patches can be applied with ease (eg. Secure Folder/Work profile, SAK), some app-specific hooks are meant to work only for that specific app (eg. Samsung Health), as applying those system-wide will probably break other stuff. Manually patching apks (same as SamsungAppsPatcher did) is also not the best way to go imho, since you'll have to update your patched apk every time Samsung releases a new update for it (and so do normal users), and you'll also need to keep in check additional checks such as the apk signature verification in some Samsung apps (which is of course not required with this module since the apk is untouched and the code is injected via the Xposed API's).