salvogiangri / KnoxPatch

LSPosed module to get Samsung apps/features working again in your rooted Galaxy device.
GNU General Public License v3.0
687 stars 31 forks source link

[FEATURE] Add Samsung SmartThings Support #31

Closed ensingerphilipp closed 10 months ago

ensingerphilipp commented 1 year ago

It would be really nice if there could be support added for Samsung SmartThings.

While this app does not show any error when opening and seems to function normally, some functionality of the app is disabled when using a rooted device - specifically this app is used to upload Location Reports of Samsung Smart Tag and this function to upload location reports of Smart Tags in your area is turned off when Knox is tripped. (would love this to be able to analyze the web traffic the app generates in this function)

I would also appreciate it if you have some docs on how you circumvent the Knox detection in the supported apps :)

Thank you!

salvogiangri commented 1 year ago

Please give a try to this test build and let me know if the issue is solved.

https://github.com/BlackMesa123/KnoxPatch/actions/runs/5291574064

ensingerphilipp commented 1 year ago

Testing right now - will get back to you - Thanks!

ensingerphilipp commented 1 year ago

Please give a try to this test build and let me know if the issue is solved.

https://github.com/BlackMesa123/KnoxPatch/actions/runs/5291574064

Unfortunately, it does not seem to resolve the issue

salvogiangri commented 1 year ago

Don't you have a screenshot of what exactly happens in the app? So I can see what is this feature you're talking about and check exactly what's wrong. Seems SAK has nothing to do with it since you're reporting nothing changed even with the patches applied

salvogiangri commented 1 year ago

When possible test this apk as well, it allows SAK key to generate rather than disabling SAK support in-app. https://github.com/BlackMesa123/KnoxPatch/actions/runs/5327027281

ensingerphilipp commented 1 year ago

Hi! Unfortunately, it's not possible for me to Screenshot when the functionality that is not working should happen, as it is a background task of the application.

Very quick explanation: Part of the SmartThings App is Samsung's Offline Finding Network that listens for BLE Advertisements of Samsung Galaxy Tags and then uploads the location of nearby Galaxy Tags encrypted to Samsung's Servers (Samsung Find (FME) Network).

This process of uploading location reports is not happening when knox is tripped (This process is not visible to the user and does not interfere with that users experience of Samsung Find - it just doesnt upload reports of other galaxy tags that are nearby). I am confident that knox is the problem as i have both identical phones that differ only in knox trip and thoroughly analyzed the functionality as part of a research project.

I will test the new patch - thank you :)!

ensingerphilipp commented 1 year ago

Unfortunately, apps behavior is still the same

salvogiangri commented 1 year ago

Unfortunately I really can't tell what's the real reason behind the issue without any detailed logs of the app. I haven't found any other relevant check in the app other than SAK that could lead to this behaviour, and as you reported it didn't fix the issue

ensingerphilipp commented 1 year ago

I can probably provide those logs if you instruct me what logs you want or point me in a direction on how to retrieve them.

salvogiangri commented 11 months ago

https://developer.android.com/tools/logcat

salvogiangri commented 10 months ago

Closing this temporarely as it's stale. @ensingerphilipp please send some debug logs when possible.