salvogiangri / KnoxPatch

LSPosed module to get Samsung apps/features working again in your rooted Galaxy device.
GNU General Public License v3.0
688 stars 31 forks source link

Not compatible with LineageOS 20 #32

Closed kaljade closed 1 year ago

kaljade commented 1 year ago

Tried installing latest version of KnoxPatch on LineageOS 20 and got "App not installed as app isn't compatible with your phone" message.

See screenshots attached.

Screenshot_20230709-090023_Package installer Screenshot_20230709-090208_Settings

salvogiangri commented 1 year ago

As stated in the repo main page and in the XDA thread, this module is only compatible with One UI: https://github.com/BlackMesa123/KnoxPatch/blob/e9ab62761d20954f0c9ee9bee3948d3c20a77a90/README.md?plain=1#L18-L24

There's no reason to support AOSP ROM's because they don't have any Knox-specific API's to hook.

kaljade commented 1 year ago

Apologies for my ignorance, I didn't actually read the original XDA thread I found your app via a different thread: https://forum.xda-developers.com/t/galaxy-wearable-app-on-rooted-phone-help.3838503/post-88085813 Do you think it's safe for me to try to install just the Magisk module without the LSPosed module as the poster suggests, or is this likely to brick my phone because it's running an AOSP rom instead of the One UI rom that both modules were designed for?

salvogiangri commented 1 year ago

Apologies for my ignorance, I didn't actually read the original XDA thread I found your app via a different thread: https://forum.xda-developers.com/t/galaxy-wearable-app-on-rooted-phone-help.3838503/post-88085813

Do you think it's safe for me to try to install just the Magisk module without the LSPosed module as the poster suggests, or is this likely to brick my phone because it's running an AOSP rom instead of the One UI rom that both modules were designed for?

No risk of bricking your device, but again, the module will refuse to install on non-One UI OS on purpose, because Knox isn't a thing in AOSP ROM's.

kaljade commented 1 year ago

Okay, thanks for clarifying, I appreciate you taking the time to explain this to me.

Cheers,

Kal