search

salvogiangri / KnoxPatch

LSPosed module to get Samsung apps/features working again in your rooted Galaxy device.
GNU General Public License v3.0
688 stars 31 forks source link

app: add Samsung China Activation support #49

Open salvogiangri opened 10 months ago

salvogiangri commented 10 months ago

Based off https://github.com/topjohnwu/Magisk/issues/7242

salvogiangri commented 10 months ago

@mio-19 @gopise mind if you give a try to this? Will implement in the next release if you confirm this fixes the issue in your end.

https://github.com/BlackMesa123/KnoxPatch/actions/runs/6160659642

mio-19 commented 10 months ago

I decided to use the Hong Kong firmware and don't have Samsung device for testing for now.

@gopise Would it be possible for you to test this patch if you happen to have an available Samsung phone?

gopise commented 10 months ago

@BlackMesa123 I'm now using a custom ROM (Aurora) which have Magisk pre-integrated and doesn't have this issue. Are you going to implement it into KnoxPatch (not Magisk)? How should i test? It will be blocked right after flash the cooked boot image. Flash it in TWRP?

salvogiangri commented 10 months ago

Are you going to implement it into KnoxPatch (not Magisk)?

If the fix works it not something that can be implemented in Magisk unfortunately. SAK generation will not work when the device's ICD status is broken (custom binaries installed), so the only way is by using KnoxPatch or a custom ROM with the SAK fix implemented.

How should i test? It will be blocked right after flash the cooked boot image. Flash it in TWRP?

Install KnoxPatch+LSPosed, make sure you select all the recommended apps, reboot and see if the activation works. The fix is implemented in the module (app) not in the Enhancer, so there's nothing to flash via recovery nor Magisk/KSU.