search

salvoventura / save-my-tabs

Open source browser extension/addon to save all open tabs to a folder in the Bookmarks Toolbar
MIT License
37 stars 5 forks source link

Feature Request: Add toggle to close all tabs after bookmarking #10

Open BeatLink opened 3 years ago

BeatLink commented 3 years ago

It would be great if there was a toggle option to close all tabs after bookmarking, that way, the user could save all their tabs, close them out then start with a fresh session

salvoventura commented 3 years ago

Hello and thanks for the submission. I'll keep this in consideration. How different would this be from closing the browser and open it afresh?

BeatLink commented 3 years ago

Well one would have to configure the browser to not load the previous session on start, which may result in data loss if they forget to use Save My Tabs first

gitfineon commented 3 years ago

Just searched for a more privacy preserving alternative to OneTab. The "officially recommended" way to bookmark all tabs of a window as a session with timestamp. The problem with OneTab is, that it uses Google for generating favicons, there is a built-in option to share the session as Link and I clicked that button inadvertently more than once. I love your AddOn for its simplicity, but it misses the feature requested here.

Am I a tab messie? Yes! Compulsive hoarding is better than never finding things again. The browser history has disappointed me too many times. Do I want to clean up with a single click? Yes, because there is not enough time to bookmark and close all tabs manually.

Current work around: Using your AddOn, selecting folder with current timestamp, save my tabs then right click the tab in the end and 'Close Multiple Tabs', 'Close other tabs', Move generated folder to 'Other Bookmarks'.

Edit: Optimized with 'about:config' flag 'browser.tabs.closeWindowWithLastTab' to false and the keyboard shortcut Ctrl+w for the last tab. Ctrl+Shift+w is currently closing the entire window instead of all tabs

Btw: Your AddOn ist ten times smaller than OneTab, faster because no favicon generation is slowing down the process and requires only the permission it should. :+1:

Edit: Just found out there is Ctrl+Shift+d to bookmark all tabs of a window to a custom folder.

gitfineon commented 3 years ago

Came back to find the built-in Firefox shortcuts I posted here and saw that there is no commit to the projects since Jan'21. In the meantime I tried some other plugins without luck. Back then I had the issue that, as I remember, Ctrl+Shift+W closed Firefox entirely, similar to Ctrl+Q. This was unacceptable to me for a similar reason @BeatLink mentioned: Data loss, for instance if there is another window with unsaved tabs or in my case the conflict with automatic restore of tabs. This would have been inconsistent with Ctrl+Shift+D because it saves only tabs of the current window, not all windows. But I looks like they somewhat solved it with closing this 13y old ticket https://bugzilla.mozilla.org/show_bug.cgi?id=490136#c26

So, I expect from now on my workflow is:

Unsolved issues from my point of view:

Don't get me wrong @salvoventura, I appreciate your plugin but in its current version, it doesn't fit my workflow.