salvoventura / save-my-tabs

Open source browser extension/addon to save all open tabs to a folder in the Bookmarks Toolbar
MIT License
37 stars 5 forks source link

Please add a button or option to manually bookmark all the open tabs across all browser windows #8

Open emCarCode opened 4 years ago

emCarCode commented 4 years ago

I appreciate your work on this extension. It's great that it can automatically bookmark all tabs in all windows, but it would really help me if you could add a button/way to manually trigger bookmarking all the open tabs across all browser windows.

Please either add an option to make it so that the "Save my tabs!" button saves tabs in all windows or, even better, add a "Save tabs in all windows!" (or something like "Save in all windows!" to make the button smaller) button next to the "Save my tabs!" button OR, even more betterer, maybe a checkbox next to the "Save my tabs!" button that says "All windows" or ("In all windows").

Also really important, if there are multiple windows open, please put each window's tabs' bookmarks in their own numbered sub-folder (under/within the folder with the date). I tend to have a different window open for browsing different types of things, so if all the tabs from all the windows are combined into one folder then I lose that organization.

Thanks a ton!

salvoventura commented 4 years ago

Thank you for the detailed description. This is definitely an interesting feature to have. However it raises some questions. The current behavior - Save my tabs - will save the tabs on the current window inside a bookmark folder, the name of which is selected by the user. It then can either append to existing bookmarks, or completely replace the folder content.

With multiple windows, as you describe, we could create numbered subfolders, one per each open window. That is great for the first run.

There is some ambiguity about what should happen when a user presses the "Save in all windows!" button a second time, to save in the same folder. In fact, a number of things can happen:

  1. the same windows are open
  2. some windows have been since closed, other new ones opened

Case #1 is simple: we just save the content in the same order, and be done Case #2 opens up some questions, to which I don't have an answer yet for a good user experience

I would like you to share you thoughts on this.

gitfineon commented 3 years ago

Case 1 should be enough for most users, but they certainly wouldn't mind if the folders get enumerated consecutively either. For Case 2 you would need a prompt somehow to add a session tag. Maybe inspired by the build-in feature to bookmark all tabs Ctrl+Shift+d for each window with the default folder naming prefilled.