search

sam-github / vpim

vCard and iCalendar support for ruby
http://vpim.rubyforge.org/
Other
142 stars 69 forks source link

Improve Vtodo support / add Maker #16

Closed dpocock closed 9 years ago

dpocock commented 9 years ago

Please let me know if this is OK

I notice some unit tests fail on the master branch even before I made any changes. The same unit tests fail after this change so I don't think I have broken anything.

Have you thought about using travis-ci to make builds of this repository?

sam-github commented 9 years ago

Tiny spelling error, but otherwise looks great.

About travis, I'm not looking for more work to do, but I'm happy to accept a PR.

dpocock commented 9 years ago

I cut and pasted that block of code (typo and all) from Vevent. I've added a commit that fixes the typos.

sam-github commented 9 years ago

:blush: and thank you.

dpocock commented 9 years ago

We are going to use Vpim for the Debian Maintainer Dashboard:

https://udd.debian.org/dmd/

Do you think you could make another tag once I finish testing Vtodo changes?

Here is what I've done so far for DMD:

http://anonscm.debian.org/cgit/collab-qa/udd.git/commit/?id=e8901fd530b344b4b6a24fe0c78a222709417d7d

sam-github commented 9 years ago

I added you as a collaborator, feel free to make the tag.

Other changes, please PR them for review. Thanks.

dpocock commented 9 years ago

Ok, thanks, I've sent the PR for travis-ci. Would you mind if I push changes to that one file as well if necessary to make it build?

sam-github commented 9 years ago

No problem, push away.​