bok-at-built
commented
2 years ago @sam-goodwin quick update here:
It looks likeTypeSafe${operationName}Command's underlying ${operationName}Command types from @aws-sdk/client-dynamodb are expecting marshalled inputs but are given the javascript objects. As an example, here is a hacky patch for Key serialization in TypeSafeGetItemCommand:
// src/get-item-command.ts
import { marshall } from "@aws-sdk/util-dynamodb";
...
export function TypeSafeGetItemCommand<
Item extends object,
PartitionKey extends keyof Item,
RangeKey extends keyof Item | undefined,
Format extends JsonFormat = JsonFormat.Default
>(): new <
Key extends TableKey<Item, PartitionKey, RangeKey, Format>,
AttributesToGet extends keyof Item | undefined,
ProjectionExpression extends string | undefined
>(
input: GetItemInput<
Item,
PartitionKey,
RangeKey,
Key,
AttributesToGet,
ProjectionExpression,
Format
>
) => GetItemCommand<
Item,
PartitionKey,
RangeKey,
Key,
AttributesToGet,
ProjectionExpression,
Format
> {
class __GetItemCommand extends _GetItemCommand {
constructor(params: ConstructorParameters<typeof _GetItemCommand>[0]) {
super({
...params,
Key: marshall(params.Key)
})
}
}
return __GetItemCommand as any
}
sam-goodwin
Hey @sam-goodwin, I'm still investigating, but I cannot get
typesafe-dynamodbto work -- my tsc is happy but the code produces a runtime error when it tries to marshall the data:This can be easily reproduced if you try to invoke one of the functions in
test/v3-document-client.test.tsagainst a locally running db (no need to create the tables since the request fails to serialize before it's sent out; you can basically just move agetcall fromfoointo the dummy test case). I suspect it has something to do with a mismatchedJsonFormatand/or a version mismatch in one of the aws dependencies.Again, I'm still investigating, but I figured you may be able to quickly diagnose the issue since you're much more familiar with these libraries than I am.