search

sam-silv / histoslider

:bar_chart: A D3 based histogram slider component for React.
http://samhogg.github.io/histoslider/
MIT License
30 stars 28 forks source link

Don't call d3Format() on handleLabelFormat unless formatLabelFunction is missing #110

Closed cpsievert closed 2 years ago

cpsievert commented 2 years ago

This way, you can use a handleLabelFormat value that d3Format() doesn't understand

Note the only real change here is https://github.com/samhogg/histoslider/pull/110/commits/3be74f91f98392ad5da87ea276ef70e8af6d7460 (the rest is files generated by yarn build)

Also, 7c44224 ignores lib/ so I can yarn install this in my own project but feel free to revert that after merging

cpsievert commented 2 years ago

No worries, thanks for the response, should be good to merge now!