search

sam-silv / histoslider

:bar_chart: A D3 based histogram slider component for React.
http://samhogg.github.io/histoslider/
MIT License
30 stars 28 forks source link

svg container has a hard coded background color of white #111

Open cpsievert opened 1 year ago

cpsievert commented 1 year ago

Which makes it not very usable with dark themes

https://github.com/samhogg/histoslider/blob/8f2d8a52d6fd44453d3cf0e2488144e9edfdcebd/src/components/Histogram.js#L55

cpsievert commented 1 year ago

Similarly, foreground colors are also hard-coded. Here's just one example:

https://github.com/samhogg/histoslider/blob/1d0f1b01eb81309a8dd0b227ef899570f6beb1c4/src/components/Slider.js#L186

It'd be better if the foreground colors defaulted to currentColor