search

sam / doubleshot

Build and Dependency Management for mixed Java/Ruby projects.
MIT License
19 stars 22 forks source link

Do not test respond_to #16

Closed sam closed 12 years ago

sam commented 12 years ago

Changing a method-name would currently break the corresponding must_respond_to tests we have. This feels wrong since we're already testing the actual call and expected behavior of the method and those tests would break anyway.

So these tests aren't increasing coverage, they're not serving as documentation really, and they're not aiding in OOD. They're just a redundant artifact.

So let's remove them.

That's my thoughts anyways. @ckrailo?

ckrailo commented 12 years ago

K

On Sep 21, 2012, at 10:01 AM, Sam Smoot notifications@github.com wrote:

Changing a method-name would currently break the corresponding must_respond_to tests we have. This feels wrong since we're already testing the actual call and expected behavior of the method and those tests would break anyway.

So these tests aren't increasing coverage, they're not serving as documentation really, and they're not aiding in OOD. They're just a redundant artifact.

So let's remove them.

That's my thoughts anyways. @ckrailo https://github.com/ckrailo?

— Reply to this email directly or view it on GitHubhttps://github.com/sam/doubleshot/issues/16.

ckrailo commented 12 years ago

Done