search

sam / doubleshot

Build and Dependency Management for mixed Java/Ruby projects.
MIT License
19 stars 22 forks source link

Aether always adds Central #64

Closed sam closed 11 years ago

sam commented 11 years ago

This seems wrong since we can't lock down repositories on TravisCI... but I'm not 100% confident.

The code I'm referencing is here: https://github.com/sam/doubleshot/blob/master/ext/java/Aether.java#L54-55

RemoteRepository central = new RemoteRepository( "central", "default", "http://repo1.maven.org/maven2/" );
repos.add(central);

If we decide to remove this, then I'm pretty sure it would just involve deleting those lines.

If it defaulted to Central when no other repository was specified (like Doubleshot does) that would be one thing, but it's actually adding it in the constructor, so you don't get the option of not adding Central.

Thoughts?

ckrailo commented 11 years ago

I agree. Not necessary, so I fixed it.

ckrailo commented 11 years ago

I should have waited for Travis CI to come back with results.

We shouldn't exclude the other repos just because we're on Travis, so we should only have if/end and not if/else/end.

Travis doesn't have a complete mirror, so it still tried some things from repo1.maven.org and got errors. Only 1 of the 3 Travis test runs had this happen.

ckrailo commented 11 years ago

@sam: Are any of the 3 non-Travis and non-Maven mirrors full mirrors? That's what we need.

sam commented 11 years ago

@ckrailo I'm not sure what you're asking. repo1 is Central. ibiblio is the main mirror for it.

I made the if...end change.

ckrailo commented 11 years ago

Ah, cool. Just making sure we have more than one complete mirror, since repo1.maven is unreliable. Close once you see it pass tests.