sam / doubleshot

Build and Dependency Management for mixed Java/Ruby projects.
MIT License
19 stars 22 forks source link

Doubleshot ignores classifier for jar dependencies #78

Closed smecsia closed 11 years ago

smecsia commented 11 years ago

This is because jar_resolver passes the "to_s" version of jar dependency to Aether. (See doubleshot/resolver/jar_resolver.rb:15):

#...
   def resolve!(dependencies)
        dependencies.each do |dependency|
          @aether.add_artifact dependency.to_s
        end
#...

As a result aether cannot find the required artifact (it tries to fetch the version without classifier).

sam commented 11 years ago

Thanks Ilya!

sam commented 11 years ago

FYI, just pushed Doubleshot v1.0.7 to Rubygems.org, so your patch should be in the wild now.