search

sam / harbor

Harbor is a Ruby Web Framework.
https://github.com/sam/harbor
MIT License
3 stars 6 forks source link

Harbor::Request shouldn't inherit from Rack::Request #89

Open Bauerpauer opened 12 years ago

Bauerpauer commented 12 years ago

Harbor::Request should not inherit from Rack::Request, and should implement all of the methods necessary to satisfy the current test suite.

jchilders commented 12 years ago

If we are targeting having Harbor::Request and Harbor::Response be "J2EE-compliant", here are the definitions for each respectively:

1) HttpServletRequest 2) HttpServletResponse

Also note that each of these inherit from a parent ServletRequest/ServletResponse interface.

There was some discussion that seemed to indicate that we could implement this functionality in a couple of days. Jetty -- and all servlet containers -- provides implementations of these that are worth investigating.

Jetty's HttpServletRequest