sam159 / brotherql_grocylabels

Brother QL Grocy Label Printer Service
MIT License
6 stars 0 forks source link

Add support for `62red` endless labels #3

Closed EnsuingRequiem closed 1 month ago

EnsuingRequiem commented 1 month ago

QL-820NWBc printers come with the 62mm endless tape which supports red. Without properly calling create_label within sendToPrinter in __init__.py, the printer will error due to an incorrect tape size. Remedy the issue by including the red parameter in the call. Review https://github.com/pklaus/brother_ql_web/blob/9e20b6dc/brother_ql_web.py#L201 for how the author of brother_ql implemented the red labels in their version of brother_ql_web

sam159 commented 1 month ago

Looks straight-forward enough, will update the issue when i've got something to test

sam159 commented 1 month ago

@EnsuingRequiem can you give the image sam159/brotherql_grocylabels:feature-red-label-support a go as see if works correctly for red labels?

EnsuingRequiem commented 1 month ago

I should be able to update my Compose file tomorrow and test it out

EnsuingRequiem commented 1 month ago

@EnsuingRequiem can you give the image sam159/brotherql_grocylabels:feature-red-label-support a go as see if works correctly for red labels?

I checked it and it prints without requiring me to make any adjustments. Thanks!

sam159 commented 1 month ago

Thanks for testing! thats all merged in now and you can switch to the latest tag :)