search

sam4413 / SELink

SELink is a powerful tool that allows Administrators easy access to their Space Engineers servers through an easy to use webpanel.
5 stars 1 forks source link

Readability. #10

Open XXX1pdwawe1XXX opened 5 months ago

XXX1pdwawe1XXX commented 5 months ago

My brother in christ, please for the love of god adopt a standard style guide.

Biggest issues I see with the codebase. I can't read it for jackshit everything is super compressed and to close together which would be ok if you're using the double space google styleguide but it is inconsistent at best and outright unreadable at worst.

Next recommendation create some form of unit testing and move your debug tests etc to another branch rather than the main it makes it harder for people to look at the code and read what's going on. In addition to this I feel some comments are distracting to people looking at the code and aren't identifying somethings properly. I also feel like the classes need more than just a basic descriptor at the top of the page to explain what's going on inside of them.

sam4413 commented 4 months ago

Hello, this project will soon be redone. ETA few months for a usable version. DM @sam44 on discord for more info