Closed iacore closed 1 year ago
Thank you for your contribution! I like the improvement. We should make it complete. I see the build_and_test
github action is failing.
There are a few things:
Parser.parseFile
should have the same return time as parseString
.Parser.alloc
.Parser.error_info
could go into Parsed
and then there is no need for Parser
at all.Do you want to address those in your PR? If it's too much, I can take it, but it will take about a week, since I'm on vacation now.
I tried your suggestion. The API would become unwieldy (like Rust Result<>
).
I want to keep the API as-is.
@iacore Thank you for the valuable contribution. I'm sorry I overlooked your reply on Jul 30th.
Parsed
isstd.json.Parsed
but simpler