Allow splitBDFAt functions to work with filepaths containing `.` and relative file paths

sam81 / BDF.jl

Module to read Biosemi BDF files with the Julia programming language

MIT License

8 stars 7 forks source link

Allow splitBDFAt functions to work with filepaths containing `.` and relative file paths #11

Closed rob-luke closed 9 years ago

sam81 commented 9 years ago

Thanks, looks good. Maybe we could refine it to cover corner cases, e.g. somebody saving the BDF file without any extension at all, but I think that should be rare.

It seems that the Travis CI build failed for the changes in the test directory files, so we may have to revert those. I'm merging for now.

rob-luke commented 9 years ago

I committed the test change first to highlight the problem, then committed the fix. Sorry that's a tad confusing, I'll just do one complete request next time.

Regarding the corner cases, I agree it should be rare, but ideally something to check. This works for now.

Thanks for accepting the PR.

sam81 commented 9 years ago

OK, all good then! I'll tag a new release with the fixes as soon as I have some time. Thanks.