search

sam81 / BDF.jl

Module to read Biosemi BDF files with the Julia programming language
MIT License
8 stars 7 forks source link

Allow use of original date and time when splitting files #12

Closed rob-luke closed 9 years ago

rob-luke commented 9 years ago

I left the default behavior as you had it, but this gives the option to use the date and time from the bdf recording.

sam81 commented 9 years ago

Hi, the old behaviour (using the date/time at which the split is occurring) was wrong (I just coded it up quickly and didn't care with these details), I think we should use the date/time from the original BDF recording as in your new version. I don't think there should be an option for the old behaviour, as it doesn't make much sense; if a user really wants to have the date/time at which the split occurs instead of the date/time from the original recording s/he can change it manually.

As for the BDF specification here http://www.biosemi.com/faq/file_format.htm the date should be in a dd.mm.yy format, so we should revert to that and check that we're consistently using this format (it may be that in the old version I was writing in a yy.mm.dd format by mistake).

rob-luke commented 9 years ago

Thanks for picking up the dd.mm.yy mistake, not sure what I was thinking there. I removed the old DateTime behaviour as you suggested.

We could add more options to pass in datetime options. But I agree, the user can adjust those things manually, this should cover most use cases.

sam81 commented 9 years ago

Thanks. Merged.