Open RyanWalker277 opened 1 year ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
.env
will still be there. Let's get on a call to explain more. I think there is some mis understanding.
Also, let's do this service by service, instead of one big PR. Also go more into different env blocks in docker compose https://docs.docker.com/compose/environment-variables/envvars-precedence/
Hey @tushar5526. As an initial PR, I have covered a few services in this one and tried to finalaise them.Since these didn't have much env vars of their own, so I just restructured the env a bit and removed docker env-file
attribute from all of them. I wasnt sure about the redis one but on testing I found out that it works just fine without the rest of the env vars, so they are'nt necessary for it's functioning. Do let me know if I missed something.
Refs
Partial fix for #33