search

samagra-comms / docker-deploy

1 stars 15 forks source link

Refactored .env for some services #46

Open RyanWalker277 opened 1 year ago

RyanWalker277 commented 1 year ago

Refs

Partial fix for #33

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 33d0ea8616038016399ad6a53304709ecc17c57e | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/33d0ea8616038016399ad6a53304709ecc17c57e#diff-f579cccc964135c7d644c7b2d3b0d3ecL11) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 33d0ea8616038016399ad6a53304709ecc17c57e | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/33d0ea8616038016399ad6a53304709ecc17c57e#diff-f579cccc964135c7d644c7b2d3b0d3ecR71) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 33d0ea8616038016399ad6a53304709ecc17c57e | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/33d0ea8616038016399ad6a53304709ecc17c57e#diff-f579cccc964135c7d644c7b2d3b0d3ecR74) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 0198b444899ed20892474d15329079dd429c9c24 | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/0198b444899ed20892474d15329079dd429c9c24#diff-f579cccc964135c7d644c7b2d3b0d3ecL72) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 0198b444899ed20892474d15329079dd429c9c24 | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/0198b444899ed20892474d15329079dd429c9c24#diff-f579cccc964135c7d644c7b2d3b0d3ecR72) | | [934781](https://dashboard.gitguardian.com/incidents/934781?occurrence=92749500) | Generic High Entropy Secret | c67da57c8830547baa362b11c2660056a1fed4f1 | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/c67da57c8830547baa362b11c2660056a1fed4f1#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dL71) | | [934781](https://dashboard.gitguardian.com/incidents/934781?occurrence=92749499) | Generic High Entropy Secret | c67da57c8830547baa362b11c2660056a1fed4f1 | .env | [View secret](https://github.com/samagra-comms/docker-deploy/commit/c67da57c8830547baa362b11c2660056a1fed4f1#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dR74) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

tushar5526 commented 1 year ago

.env will still be there. Let's get on a call to explain more. I think there is some mis understanding.

tushar5526 commented 1 year ago

Also, let's do this service by service, instead of one big PR. Also go more into different env blocks in docker compose https://docs.docker.com/compose/environment-variables/envvars-precedence/

RyanWalker277 commented 1 year ago

Hey @tushar5526. As an initial PR, I have covered a few services in this one and tried to finalaise them.Since these didn't have much env vars of their own, so I just restructured the env a bit and removed docker env-file attribute from all of them. I wasnt sure about the redis one but on testing I found out that it works just fine without the rest of the env vars, so they are'nt necessary for it's functioning. Do let me know if I missed something.