samagra-comms / docker-deploy

1 stars 15 forks source link

Renamed services for better readability #51

Closed RyanWalker277 closed 1 year ago

RyanWalker277 commented 1 year ago

Fixes #50

Renamed the services for better readability and updated all the dependencies. Let me know if I missed something.

tushar5526 commented 1 year ago

These names are a bit overkill. What needed to be changed was the naming of Redis services. Apart from that every other thing was already correct. Prepending by uci is also not required. Docker-Compose prepends the name of the folder in which compose exists to containers.

RyanWalker277 commented 1 year ago

There are thre redis services defined in the docker compose :

In all the three cases, according to the original ticket, uci-api-scheduler-db can be the one which is misnamed as a db, but it seems that this isn't being used anywhere ( #45 ), so I would need a bit more clarity on this. Also, what needs to be done of the redis instance ( named redis )? As far as I can understand, it's also not being used by any other service. Should it be removed or is it being used at the server end?

cc - @chinmoy12c @pankajjangid05