samagra-comms / inbound

0 stars 15 forks source link

Update Dockerfile #64

Open Aartipandey01 opened 1 year ago

Aartipandey01 commented 1 year ago
  1. Updated the base image in the second stage: I replaced the base image ibm-semeru-runtimes:open-11.0.18_10-jre with adoptopenjdk:11-jre-hotspot.

2.Removed the unnecessary environment variable export $(cat .env | xargs)

chinmoy12c commented 1 year ago
  1. Updated the base image in the second stage: I replaced the base image ibm-semeru-runtimes:open-11.0.18_10-jre with adoptopenjdk:11-jre-hotspot.

2.Removed the unnecessary environment variable export $(cat .env | xargs)

Hey Aarti, why are these changes needed? What is the advantage of using another JVM?

Aartipandey01 commented 1 year ago

why are these changes needed? What is the advantage of using another JVM?

@chinmoy12c , The advantage of using "adoptopenjdk:11-jre-hotspot" is that it is a widely-used and community-supported distribution of OpenJDK, which provides an open-source implementation of the JDK and the JRE,

  1. Line "ENV export $(cat .env | xargs)" in the second stage, which reads environment variables from a file named ".env" and exports them, has been removed bcz eliminate unnecessary complexity and potential security risks.