search

samalba / dockerclient

Docker client library in Go
http://www.docker.com/
Apache License 2.0
322 stars 140 forks source link

Deprecate in favour of docker/engine-api #238

Closed bfirsh closed 8 years ago

bfirsh commented 8 years ago

A bunch of projects use this library, so we probably shouldn't abandon it, but it would perhaps be sensible to suggest people try using https://github.com/docker/engine-api instead.

Is there anything missing from docker/engine-api that would stop users from being able to use it instead of this library?

/cc @samalba @vieux

vieux commented 8 years ago

I would say event management, it's pretty rough in https://github.com/docker/engine-api

bfirsh commented 8 years ago

@vieux Specifically what about event management is lacking? I want to open an issue against docker/engine-api about this, but not sure exactly what to say. :)

vieux commented 8 years ago

@bfirsh all the complicated code here https://github.com/samalba/dockerclient/blob/master/dockerclient.go#L472 that parses events and return them via channel, etc...

last time I looked the only thing in engine-api was a GET /events but you have to do most of the rest by hand

thaJeztah commented 8 years ago

/cc @vdemeester (we were talking about this a while back, re: events)

vdemeester commented 8 years ago

@bfirsh @vieux yeah, the events in engine-api is pretty bare-metal. I've created a library docker-events (that we use in libcompose) to make it a little useful and was wondering if we should have some code like that in engine-api.

bfirsh commented 8 years ago

@vieux @vdemeester Thanks, this is really helpful.

@vdemeester Agreed something like that should probably be in engine-api. I've opened https://github.com/docker/engine-api/issues/246 to keep track.