search

samamidis / google-maps-utility-library-v3

Automatically exported from code.google.com/p/google-maps-utility-library-v3
Apache License 2.0
0 stars 0 forks source link

MarkerManager for v3 #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
It's a direct port of the markermanager from the v2 library.

When reviewing my code changes, please focus on:
The ProjectionHelper class, Bounds class and parts where you find v3
syntax. Don't forget the examples ;)

After the review, I'll merge this branch into:
Who knows, releases i guess ;)

Original issue reported on code.google.com by bbr...@gmail.com on 3 Mar 2010 at 10:32

GoogleCodeExporter commented 9 years ago 
Reviewed the following files:

http://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/mark
ermanager/src/markermanager.js?spec=svn81&r=80#44
http://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/mark
ermanager/examples/weather_map.html?spec=svn81&r=81#22
http://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/mark
ermanager/examples/google_northamerica_offices.html?spec=svn82&r=79#24

I actually reviewed the wrong revision, but we'll work it out later on.

Let me know if you have any questions about the comments.

Original comment by daniel...@google.com on 9 Mar 2010 at 11:52

GoogleCodeExporter commented 9 years ago 
Thanks for the review, i will apply the changes you suggest, as soon as i can, 
but
will need to do it at home.

Original comment by bbr...@gmail.com on 10 Mar 2010 at 8:30

GoogleCodeExporter commented 9 years ago 
I changed the suggestions. I only didn´t comment on the bit shift because i 
really
can´t find the words at 8pm on friday :)

Commmited Revision 84

Original comment by bbr...@gmail.com on 12 Mar 2010 at 6:50

GoogleCodeExporter commented 9 years ago

Original comment by daniel...@google.com on 17 Mar 2010 at 9:33