samanthasgroup / django-webapps

Backend for the database, implemented in Django
Other
3 stars 0 forks source link

Make `.personal_info.id` clickable in table of `Coordinator`s #512

Closed SivikGosh closed 6 months ago

SivikGosh commented 7 months ago

closes #505

Initially this was an attempt to make the whole row clickable, but it's too difficult and may not be worth the effort for now

Auch-Auch commented 7 months ago

@lemontree210 In general I think we should not focus on such tasks at all. We can do the following: whatever cosmetic changes (which do not affect target business logic) requested by the owners should be put at one task under list of sub-tasks and do it only if it is possible to implement it via standard django admin interface (meaning without much effort) otherwise we will never release. Django admin UI is designed not to increase KPI but to provide fastly built MVP out of existing components which is exactly what we need. In any possible case it will be batter then EXCEL sheets

lemontree210 commented 7 months ago

In general I think we should not focus on such tasks at all.

I see your point. I outlined my rationale here, and here I can just repeat that, given my concerns over ToolJet's stability, these tasks become not just 'cosmetic' but potentially very important UX features

lemontree210 commented 7 months ago

Whatever cosmetic changes (which do not affect target business logic) requested by the owners should be put at one task under list of sub-tasks

This is exactly what I did, I think :) See #506

... and do it only if it is possible to implement it via standard django admin interface (meaning without much effort)

Here's where I disagree: when picking Django, we never made decisions to stick only to ready-made things

otherwise we will never release.

I understand your concern, but see, our colleagues doing ToolJet are still working on the owners' comments, some of which concern basic functionality, and our bot 'division' is behind the schedule as well, because it consists only of me, while all other potential developers that could help with the bot are unavailable at the moment. So by asking @SivikGosh to do these features, I

  1. Do not delay the release of MVP
  2. Try to move towards potentially replacing ToolJet. All of these 'cosmetic' changes will be applicable to any other model in Django admin: students, teachers, and groups.

In any possible case it will be batter then EXCEL sheets

Agreed, but being just "better than Google Sheets" is not enough :(

lemontree210 commented 7 months ago

@Auch-Auch @SivikGosh all in all, in this concrete task I would say that making full_name clickable is already more intuitive for the owners. Maybe we should do the following:

SivikGosh commented 7 months ago

@lemontree210 @Auch-Auch, maybe we should make coordinator's pages, outer from admin panel? With Django templates and personal path.

lemontree210 commented 6 months ago

@lemontree210 @Auch-Auch, maybe we should make coordinator's pages, outer from admin panel? With Django templates and personal path.

Sorry for the delayed reply! I'm not sure what you mean here, sorry :)

lemontree210 commented 6 months ago

@Auch-Auch @SivikGosh all in all, in this concrete task I would say that making full_name clickable is already more intuitive for the owners. Maybe we should do the following:

  • stick with making full_name clickable for now and save the template-changing ideas for later

I implemented this for now. @Auch-Auch please approve to observe formalities :)