search

samanzamani / PersianDate

Persian date for android
BSD 3-Clause "New" or "Revised" License
326 stars 40 forks source link

English Support for Month & Weekday Names #65

Closed yasanglass closed 2 years ago

yasanglass commented 2 years ago

Currently, we can only get the date strings in Persian but in some scenarios, it's better to show the Persian date in English characters. It would be really useful to have the option to get the date in English instead of Persian.

samanzamani commented 2 years ago

Hi @yasandev Farsi characters were added in v1.3.3 and you can choose between Farsi and English characters when you use PersianDateFormater class.

You can check https://github.com/samanzamani/PersianDate/issues/46 issue

yasanglass commented 2 years ago

I want pretty much the opposite of that. I want to format my Persian dates into strings like these: Shanbe 1 Khordad and Saturday 1 Khordad.

These can be useful for projects where Persian Date should be supported but the app wants to respect the device's language; showing Persian Date but in English.

It looks like #66 adds what I am requesting except for being able to show weekdays in English.

samanzamani commented 2 years ago

I see. I didn't think it was a practical feature. Since @ftml71 already implemented this feature I will check her contribution then merge the pull request and distribute a new version.

samanzamani commented 2 years ago

Pull request merged and a new version was released. This feature is available from v1.5.1.