samarsault / plainwhite-jekyll

A configurable portfolio-style jekyll theme for writers.
https://samarsault.com
MIT License
460 stars 480 forks source link

Add compatibility with baseurl tag #69

Closed AlexVerrico closed 4 years ago

AlexVerrico commented 4 years ago

Hi @samarsault I have made the following changes to this theme to make it compatible with the tag baseurl:

Cheers, Alex.

samarsault commented 4 years ago

Thanks @AlexVerrico! This is, indeed, a much needed feature. I've made some comments, and once those are resolved this should be good to go.

AlexVerrico commented 4 years ago

@samarsault I have addressed both of your comments

samarsault commented 4 years ago

Also, please squash your commits.

AlexVerrico commented 4 years ago

Hi @samarsault I have made the changes that you suggested in your comments. Regarding squashing the commits, there is normally an option for you to do that when you merge this branch into master. Cheers, Alex.

samarsault commented 4 years ago

Looks great, thanks!