Closed AlexVerrico closed 4 years ago
Thanks @AlexVerrico! This is, indeed, a much needed feature. I've made some comments, and once those are resolved this should be good to go.
@samarsault I have addressed both of your comments
Also, please squash your commits.
Hi @samarsault I have made the changes that you suggested in your comments. Regarding squashing the commits, there is normally an option for you to do that when you merge this branch into master. Cheers, Alex.
Looks great, thanks!
Hi @samarsault I have made the following changes to this theme to make it compatible with the tag
baseurl
:baseurl
tag (minor change)_layouts/default.html
as relative URLs (meaning that they will have the value ofbaseurl
prepended to them) (minor change)assets/js/search.js
as an external script to embedding it in_layouts/default.html
to allow for the value ofbaseurl
to be prepended to the path tosearch.json
(major change)Cheers, Alex.