samarsault / texture

A configurable jekyll theme for simply beautiful blogs.
https://samarsault.com/texture
MIT License
221 stars 341 forks source link

Links for the navigation panel missing #21

Closed kdzhang closed 4 years ago

kdzhang commented 4 years ago

Thank you a lot for creating this beautiful theme! I am very new to Jekyll and Ruby since this is my first time trying to build my own blog, so I apologize if my question is naive.

I tried to turn on the navigation feature by setting showNav: true. Unfortunately, although the navigation panel is there, clicking it has no effect.

I thought the problem is in _includes/nav.html, where we have:

{%- if site.texture.showNav -%}
<div class="navbar">
    <ul>
        <a href="#"><li>Home</li></a>
        <a href="#"><li>About</li></a>
    </ul>
</div>
{%- endif -%}

I changed it to below and it works.

{%- if site.texture.showNav -%}
<div class="navbar">
    <ul>
        <a href="/#/"><li>Home</li></a>
        <a href="/about/"><li>About</li></a>
    </ul>
</div>
{%- endif -%}

Am I doing the right thing? Or there is actually a method to automatically create the links?

Thank you!

samarsault commented 4 years ago

Yes that's the right way :')