search

samarthhapse / sarthi

48 stars 77 forks source link

Adding an eye button in the password field #176

Closed pani2004 closed 4 months ago

pani2004 commented 5 months ago

I can add a eye button for pw visibility in the login page Screenshot 2024-06-17 220719

pani2004 commented 5 months ago

@samarthhapse Can I work on this?

KavyaBS123 commented 5 months ago

Hey @samarthhapse I am VSoC contributor can you please assign this issue to me I would like to work on it!

themdazad commented 5 months ago

I can easily implement it by changing Input type dynamically by clicking on eye icon placed in inside input field. ![Uploading azad_ type password.jpg…]()

samarthhapse commented 5 months ago

@pani2004 , pls start working on this issue and raise PR asap

samarthhapse commented 5 months ago

@KavyaBS123 , have you worked on video meet bot in MERN stack ?

KavyaBS123 commented 5 months ago

Hey @samarthhapse yup! I have worked on it quite a few times

samarthhapse commented 5 months ago

okay @KavyaBS123 , comment on #89 . If you can complete it within 4 to 5 days

samarthhapse commented 5 months ago

@pani2004 please comment once you have started resolving this issue. So I can ad you as assignee

KavyaBS123 commented 5 months ago

okay @KavyaBS123 , comment on #89 . If you can complete it within 4 to 5 days

Sure sure I am on it!

pani2004 commented 5 months ago

@samarthhapse Yess I am on it

samarthhapse commented 5 months ago

Okay @pani2004

pani2004 commented 5 months ago

@samarthhapse pls assign me

samarthhapse commented 5 months ago

Assigned

samarthhapse commented 5 months ago

@pani2004 you added it only for signin. Pls add it for signup also

pani2004 commented 5 months ago

ok @samarthhapse

samarthhapse commented 5 months ago

@pani2004 done ?

pani2004 commented 5 months ago

@samarthhapse should I make a new PR for this?

samarthhapse commented 5 months ago

Yesss

pani2004 commented 5 months ago

okk

pani2004 commented 5 months ago

@samarthhapse check the PR