samarthhapse / sarthi

53 stars 71 forks source link

Added sign in with google and sign up with google in both student and expert page #191

Closed Krishna100604 closed 17 hours ago

Krishna100604 commented 1 week ago

Screenshot (123) Screenshot (122) Screenshot (125) Screenshot (124)

@samarthhapse assign me this issue

Krishna100604 commented 1 week ago

assign me this under vsoc'24

ROKUMATE commented 1 week ago

@Krishna100604 Its the same Issue Of #128 and its added in the code base ig

Krishna100604 commented 1 week ago

@Krishna100604 Its the same Issue Of #128 and its added in the code base ig

no i just forked it today it's not added

ROKUMATE commented 1 week ago

its updated on temp branch not temp4 one ig

Krishna100604 commented 1 week ago

its updated on temp branch not temp4 one ig

okk

samarthhapse commented 1 week ago

@ROKUMATE pls see above shared images by Krishna. This was what I was expecting you to do. Nut you have changed the UI completely and I think some part of backend also. You were actually expected to only add one button for signin with google(not changing the the UI of complete pages of student and expert)

Krishna100604 commented 1 week ago

@ROKUMATE pls see above shared images by Krishna. This was what I was expecting you to do. Nut you have changed the UI completely and I think some part of backend also. You were actually expected to only add one button for signin with google(not changing the the UI of complete pages of student and expert)

can you assign it to me

samarthhapse commented 1 week ago

Hello Krishna firstly let @ROKUMATE comment here , then I will surely assign tp you

Krishna100604 commented 1 week ago

Hello Krishna firstly let @ROKUMATE comment here , then I will surely assign tp you

okk

samarthhapse commented 1 week ago

@ROKUMATE he deserves the acceptance for this one. Because he actually worked on this for 2 days. But got into the confusion

samarthhapse commented 1 week ago

@Krishna100604 pls wait !

Krishna100604 commented 1 week ago

@ROKUMATE he deserves the acceptance for this one. Because he actually worked on this for 2 days. But got into this confusion

hmm ohk

samarthhapse commented 1 week ago

@Krishna100604 , pls start working on this. I have assigned it to you

samarthhapse commented 1 week ago

@Krishna100604 for adding labels , from which program you are contributor gssoc'24 OR vsoc'24

Krishna100604 commented 1 week ago

@Krishna100604 for adding labels , from which program you are contributor gssoc'24 OR vsoc'24

vsoc'24

samarthhapse commented 1 week ago

okay @Krishna100604 added labels , pls fork latest code from latest temp branch and raise PR asap

Krishna100604 commented 1 week ago

@samarthhapse i created PR

Krishna100604 commented 1 week ago

BTW how many points will i get

samarthhapse commented 1 week ago

@Krishna100604 Are you able to signin/up with google properly as student and expert as well

Krishna100604 commented 1 week ago

@Krishna100604 Are you able to signin/up with google properly as student and expert as well

you need to create a client key for that like API key for authentication it is just a UI i made

samarthhapse commented 1 week ago

@Krishna100604 Are you able to signin/up with google properly as student and expert as well

you need to create a client key for that like API key for authentication it is just a UI i made

That's the main thing Krishna. You are expected to implement completely

Krishna100604 commented 1 week ago

okk i will try

samarthhapse commented 1 week ago

@Krishna100604 Can you surely complete it surely by today

Krishna100604 commented 1 week ago

no by tomm i can finish

Krishna100604 commented 1 week ago

but i think for backend you have to create an api and client key for google auth since it is your project so i can not crate my api key

samarthhapse commented 1 week ago

you can create of your own for you to use

samarthhapse commented 1 week ago

@Krishna100604 are you ready to complete it

Krishna100604 commented 1 week ago

okk i try

samarthhapse commented 1 week ago

@Krishna100604 , If you try and take 2 days. And if task is not completed then it may waste time of the project

samarthhapse commented 1 week ago

@Krishna100604 can I assign it to Rohit ?

Krishna100604 commented 1 week ago

yeah if he can do it you can assign him maybe i work on another feature

samarthhapse commented 1 week ago

okay

samarthhapse commented 1 week ago

@ROKUMATE can you complete this issue as per frontend of Krishna

samarthhapse commented 1 week ago

@ROKUMATE once pls , go through Krishna's PR. If I merge his PR , can you add your code. OR you want to make it completely of your own

ROKUMATE commented 1 week ago

@samarthhapse Sir i have already created the functionality using the Appwrite package ... that is what my pull request was ...

what u want mee to do exactly in the code now can you specify ?

samarthhapse commented 1 week ago

@ROKUMATE you have to copy paste same code for current temp branch without changing ui of current signin/up pages. Just add buttons like krishna's shared images

ROKUMATE commented 1 week ago

Ohk sir i will do it 👍

ROKUMATE commented 1 week ago

so sir you gonna merge his pull request then i have to work naa as of now the ui is not updated yet in the codebase

samarthhapse commented 1 week ago

@ROKUMATE , merged the PR of Krishna. Pls start working.

samarthhapse commented 1 week ago

@ROKUMATE Pls try to complete by today. I also have some more issues for you as you are experienced in MERN

samarthhapse commented 1 week ago

@ROKUMATE added you as assignee and level3 label too. Pls hurry !

ROKUMATE commented 1 week ago

@samarthhapse If u want any changes in that do tell,

else the issue is completed now

samarthhapse commented 1 week ago

@ROKUMATE I will merge your PR within two days. Cany you wok on integrating chat box functionality for the app in MERN stack completely

Krishna100604 commented 1 week ago

@samarthhapse you didn't give me points for last PR