Closed AADESHak007 closed 2 months ago
It would be really appreciable if you could assign this task to me I will be able to solve it by today .
@AADESHak007 , this issue is not that urgent. but if you can work on below problem issue so pls comment below and start building. I will assign you =>
Issue => Whenever any expert try to sign up here , owner of website (example@gmail.com) should get a mail to review that expert. When owner verify the expert then only the expert profile should get created
Hey @samarthhapse thank you for the reply . I would like to check it out . So please assign the task to me . I will be able to solve it . Waiting for your respond . Thank you
great ! pls start working. Assigned the task to you
please complete it on urgent basis
thanks . I will do it within 2 days .
okay, go ahead !
hello , @AADESHak007 , to make your task simple. I have added complete code for email verification. Please clone the current branch (updates) and check it out
@AADESHak007 hope you haven't started yet
@AADESHak007 a PR for this issue is raised by one previous contributor. Pls don't mind , but I have to merge it.
@AADESHak007 , if you are well experienced in mern backend so I can assign you another issue. Are you ready ?
Actually I had built a working code for the whole feature and was testing it on my local app and system, but no worries I ll check it and tell you if there are any upgrades that we can do
I want to contribute on the project so please feel free assign me a task .
@AADESHak007 , currently when I try to authorize expert , I have to do it from localhost only. Do you have any solution for it. So I can authorize from that mail id without localhost
If you have completed , pls share the complete working video of your solution
@AADESHak007 if I find your task better than current one I will merge your PR
@AADESHak007 pls share the video
I have checked the code and it looks good to me . However I was also working on the last part . If the administrator confirms the registration then the user should get a code that could get verified first then only the expert is allowed to register.
Currently it is on click of link so it is needing localhost. If we integrate code verification, we will not need localhost. It will go smooth like otp verification.
@AADESHak007 pls try to make it and raise PR
@AADESHak007 pls try to make it and raise PR. Is it possible by tonight ?
I ll try to do it by tonight .. I ll do it when I reach home at 7
Okay @AADESHak007
DONE✅
Hey @samarthhapse i have completed the whole thing and it is working fine . SCREENSHOTS
before creating a PR I have change the whole auth-expert.js . If you are fine with that then only I will do that . PLEASE RESPOND ASAP..
@AADESHak007 , but you must be careful that rest of the functionalities based on auth-expert.js should work properly
@AADESHak007 also while sending mail pls try to share the details with it like below image
@samarthhapse please check the new branch /feat/authorization-updated
Describe the bug For checking if the user already exists or not you are making 2 DB calls that is really expensive in the context of development.
Proposed Solution I can optimize the code for you and will check for some optimizations too.
Screenshots
Desktop (please complete the following information):