search

samau3 / mynintendo-scraper

A fullstack web app that scrapes My Nintendo Rewards, connected to a Discord Bot
https://mynintendo-scraper.vercel.app
0 stars 0 forks source link

Prevent Trademark from triggering a change #67

Closed samau3 closed 7 months ago

samau3 commented 8 months ago

Before, using the deepdiff library would include changes in item names when the trademark symbol was added or removed. This caused false positives, indicating both the addition of a new item and the removal of an existing one. This issue occurred due to the presence or absence of the trademark symbol being treated as an addition of a new item, while the original item's absence was treated as its removal.

Given the risk that these changes can have in preventing a change from being determined properly, tests have been added with the various edge cases that may happen to ensure those scenarios are handled properly.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mynintendo-scraper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 1:08am