samaxes / minify-maven-plugin

Combine and minimize JavaScript and CSS files for faster page loading.
http://samaxes.github.com/minify-maven-plugin
Apache License 2.0
222 stars 91 forks source link

minify fails when using maven4 #174

Open plitter opened 2 years ago

plitter commented 2 years ago

I got help from here and it seems to be an easy fix where you add dependency on plexus-utils. Sample test is the foobar.zip. https://issues.apache.org/jira/browse/MNG-7355

blutorange commented 1 year ago

This also now happens with Maven 3.9, where plexus-utils was removed #176

Quick fix is to add a dependency to the plugin like this:

                <plugin>
                    <groupId>com.samaxes.maven</groupId>
                    <artifactId>minify-maven-plugin</artifactId>
                    <version>${minify-maven-plugin.version}</version>
                    <dependencies>
                        <!-- https://github.com/samaxes/minify-maven-plugin/pull/176 -->
                        <dependency>
                            <groupId>org.codehaus.plexus</groupId>
                            <artifactId>plexus-utils</artifactId>
                            <version>${plexus-utils.version}</version>
                        </dependency>
                    </dependencies>
                </plugin>
dsueltenfuss commented 1 year ago

Is there a release timeline for this fix?

sasuw commented 1 year ago

For people stumbling upon this error and looking for a quick solution:

<plugin>
    <groupId>com.7p-group</groupId>
    <artifactId>minify-maven-plugin</artifactId>
    <version>1.7.8</version>
</plugin>

This issue is fixed in the forked repo https://github.com/sevenprinciples/minify-maven-plugin