search

samay-app / samay

Find a time which works for everyone
https://samay.app
MIT License
307 stars 60 forks source link

Provide a one-click Heroku deployment button #154

Closed anandbaburajan closed 3 years ago

anandbaburajan commented 3 years ago

https://devcenter.heroku.com/articles/heroku-button would help.

subhangi2731 commented 3 years ago

can you please assign this issue to me?

Ayushisood commented 3 years ago

Hii @AnandBaburajan I would like to contribute to this task as a GSSOC'21 participant. Kindly assign this task to me so as i can also experience the open source learning.

anandbaburajan commented 3 years ago

Hi @Ayushisood! Thanks! You're suggested to join our Gitter chatroom too! @subhangi2731 since you've shown interest in lots of issues, we would appreciate it if you chose and solved a few of them first. Thanks!

Ayushisood commented 3 years ago

Hi @Ayushisood! Thanks! You're suggested to join our Gitter chatroom too! @subhangi2731 since you've shown interest in lots of issues, we would appreciate it if you chose and solved a few of them first. Thanks!

Okay , Thank you sir!

anandbaburajan commented 3 years ago

Okay , Thank you sir!

No need to use 'sir' or 'ma'am' at any open source organisation and your workplace. Simply call us by name or @ at us. :)

Ayushisood commented 3 years ago

Hi @Ayushisood! Thanks! You're suggested to join our Gitter chatroom too! @subhangi2731 since you've shown interest in lots of issues, we would appreciate it if you chose and solved a few of them first. Thanks!

@AnandBaburajan can you provide the link of Gitter chatroom

anandbaburajan commented 3 years ago

can you provide the link of Gitter chatroom

You can find it from our readme.

Ayushisood commented 3 years ago

{ "name": "rocketmeet", "description": "Server for RocketMeet — a free and open source meeting scheduling app using Node.js", "repository": "https://github.com/RocketMeet/RocketMeet.git", "logo": "https://github.com/RocketMeet/RocketMeet-server/raw/main/server.png", "keywords": ["node"] }

this is the app.json file to be included in the repo @AnandBaburajan Is this file okay or need to change something or need to add add-ons, custom environment variables?????

anandbaburajan commented 3 years ago

Is this file okay or need to change something or need to add add-ons, custom environment variables?????

Users would definitely need to specify env/config vars. Also buildpacks should contain heroku/nodejs. This might help: https://devcenter.heroku.com/articles/app-json-schema. You can also check out how popular projects using a Node.js web server provide a Heroku button.

Ayushisood commented 3 years ago

@AnandBaburajan WhatsApp Image 2021-03-11 at 22 53 42 I am getting this error while running packege.json file.. can you help me out with this?

anandbaburajan commented 3 years ago

I did a quick Google search on "node env is not recognized as an internal or external command" since LOG_LEVEL is an env. I found this SO question. After reading the first answer, I'm assuming that you're on Windows. The current method only works in Linux platforms. So thanks for finding that out! Though you could try out the first solution, this solution would be preferred since it's cross-platform.

Ayushisood commented 3 years ago

@AnandBaburajan its working now on windows, but the get request is not working, can you please send me the screenshot of landing page ? and help me with the get request. Thank you.

anandbaburajan commented 3 years ago

@AnandBaburajan its working now on windows.

You used the cross-platform solution right? Just to clarify.

but the get request is not working.

Can you provide the response of the request?

can you please send me the screenshot of landing page ?

Didn't get you, landing page of?

Ayushisood commented 3 years ago

@AnandBaburajan , yes used the cross platform solution. WhatsApp Image 2021-03-12 at 13 22 46 WhatsApp Image 2021-03-12 at 13 22 47

anandbaburajan commented 3 years ago

Ah, why are you trying to access /? There are no endpoints on that route. Could you please share what you're trying to achieve? Also, thanks for adding cross-env! Can you also add it to the test script so that tests work for you too?

Ayushisood commented 3 years ago

Ah, why are you trying to access /? There are no endpoints on that route. Could you please share what you're trying to achieve?

I just want to know that what should be visible to me when I run the local host?? As for now it is showing nothing. Please guide me.

Also, thanks for adding cross-env! Can you also add it to the test script so that tests work for you too?

Sure , I will add that to test script also.

anandbaburajan commented 3 years ago

I just want to know that what should be visible to me when I run the local host??

The RocketMeet-server provides a RESTful service which is used by the RocketMeet-client to create polls, get polls, mark available times and more. You can test out the different API routes using Postman if you wish. Here's the API documentation.

If you want to run https://rocketmeet.me/ locally, you need to fork and run the RocketMeet-client.

anandbaburajan commented 3 years ago

If the doubts are not related to this particular issue, feel free to ask them at out chatroom too! :D

Ayushisood commented 3 years ago

@AnandBaburajan Made a PR, please check it once and let me know if any further changes need to incorporate.

anandbaburajan commented 3 years ago

@AnandBaburajan Made a PR, please check it once and let me know if any further changes need to incorporate.

I checked your PR but I don't know actually what's required and what's correct. That's why we're glad to have you here because you'll help us with it! Thanks :D

Ayushisood commented 3 years ago

I checked your PR but I don't know actually what's required and what's correct. That's why we're glad to have you here because you'll help us with it! Thanks :D

Sure thing :)